Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cases where the request is done with transfer-encoding chunked #589

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Support cases where the request is done with transfer-encoding chunked #589

merged 3 commits into from
Apr 18, 2018

Commits on Apr 18, 2018

  1. Support cases where the request is done with transfer-encoding chunked 

    PR grpc-ecosystem#527 was put in place to fix an issue where an empty request body
would cause an empty message to be sent down to the GRPC service
(instead of failing). The fix at the time was to check that the
ContentLength was >0, but this doesn't take into consideration
transfer-encoding chunked POSTs. Since this patch all chunked POSTs
no longer unmarshal the message (as the content-length was 0).

My proposed fix is instead to always call Decode and simply ignore EOF
errors (as we still want to pass the un-filled struct down). I have
tested that things such as partial json blobs (something like '{') don'
t return EOF (they have their own json error).
    @jacksontj
    jacksontj committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    2443650 View commit details
    Browse the repository at this point in the history

  2. Regenerate tests

    @jacksontj
    jacksontj committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    b0f39d5 View commit details
    Browse the repository at this point in the history

  3. Add test case where request is send as a chunked-encoded request

    @jacksontj
    jacksontj committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    cdf19f8 View commit details
    Browse the repository at this point in the history