Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix noenc error by fixing Details error field #557

Merged
merged 1 commit into from
Feb 24, 2018
Merged

fix noenc error by fixing Details error field #557

merged 1 commit into from
Feb 24, 2018

Commits on Feb 24, 2018

  1. fix noenc error by fixing Details error field 

    As advised by @itizir in the discussion of grpc-ecosystem#551.

However, I've gone with the minimal change to make the error go away, I
haven't introduced a proper, generated protobuf definition.

Also, I've noticed our error body message there looks suspiciously like
Status[1], except for the field name "Error" vs "Message".

Fixes grpc-ecosystem#551.

[1]: https://github.com/google/go-genproto/blob/2b5a72b8730b0b/googleapis/rpc/status/status.pb.go#L83-L93

Signed-off-by: Stephan Renatus <srenatus@chef.io>
    @srenatus
    srenatus committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    82232d2 View commit details
    Browse the repository at this point in the history