Update go version #5265
Merged
Update go version #5265
+36
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
force-pushed
the
update-go-version
branch
from
f011d59 to
88ef6e4
Compare
johanbrandhorst
force-pushed
the
update-go-version
branch
from
88ef6e4 to
da8ff07
Compare
|
How come this was ported to v2.26.2? This is a rather breaking change because people who use go1.23 would not be able to upgrade from v2.26.1 to v2.26.2. I'm ok with not being allowed to use v2.27.0 (for example) until upgrading to go1.24, but this is a patch version upgrade, so I'd expect to be able to use it with the same go version (unless the patch requires go1.24, but it does not seem like it's required?) |
|
This change has been reverted in https://github.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.26.3. Sorry for the inconvience. |
|
oh wow that was fast. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.