Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add codecov #514

Merged
merged 1 commit into from
Jan 3, 2018
Merged

ci: add codecov #514

merged 1 commit into from
Jan 3, 2018

Conversation

tmc
Copy link
Collaborator

@tmc tmc commented Jan 2, 2018

Fixes #513

achew22
achew22 reviewed Jan 2, 2018
View reviewed changes
.travis.yml Outdated
@@ -4,6 +4,7 @@ go:
- 1.7.x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should drop 1.7.x right now and drop 1.8.x when 1.10 is released

Copy link
Collaborator Author

@tmc tmc Jan 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not clear that supporting this far back incurs much cost

@tmc
Copy link
Collaborator Author

tmc commented Jan 2, 2018

Hm, oddly hitting an infinite recursion issue when trying to run coverage.

@achew22
Copy link
Collaborator

achew22 commented Jan 2, 2018

I think we should remove the 1.10 beta from the test matrix. I'm sure we aren't the only people hitting that and we don't have release notes on how to fix this yet

@tmc
Copy link
Collaborator Author

tmc commented Jan 2, 2018

I wanted/needed it for coverage output consolidation. (-coverpkg=all)

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c1c70b3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #514   +/-   ##
=========================================
  Coverage          ?   60.17%           
=========================================
  Files             ?       28           
  Lines             ?     2669           
  Branches          ?        0           
=========================================
  Hits              ?     1606           
  Misses            ?      905           
  Partials          ?      158

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c70b3...57e1c5a. Read the comment docs.

@achew22 achew22 merged commit 61c34cc into grpc-ecosystem:master Jan 3, 2018
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
@tmc @achew22
ci: add codecov (grpc-ecosystem#514)
e15945a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achew22 achew22 achew22 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmc @achew22 @codecov-io