Add support for non-nullable nested messages. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested messages with "[(gogoproto.nullable) = false]" option are generated as structs, rather than pointers to structs. Add support for such struct values to populate parameter functionality. Add test case. Resolves #20.
|
LGTM. Thank you for your contribution. |
yugui
added a commit
that referenced
this pull request
Jun 19, 2015
Add support for non-nullable nested messages.
ithinker1991
referenced
this pull request
in tronprotocol/grpc-gateway
Apr 26, 2018
add GetDynamicProperties rpc api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested messages with "[(gogoproto.nullable) = false]" option are generated as structs, rather than pointers to structs. Add support for such struct values to populate parameter functionality.
Add test case.
Resolves #20.
This PR is in need of review and discussion before merging.