Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only canonicalize header key once in each iteration #1564

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

ziyi-yan
Copy link
Contributor

@ziyi-yan ziyi-yan commented Jul 31, 2020

References to other Issues or PRs

No related issue exists yet.

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

Move canonicalizing header key to outer loop for doing it only once for each key

Other comments

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johanbrandhorst johanbrandhorst merged commit 3c7c499 into grpc-ecosystem:master Jul 31, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you please cherry pick this against the v2 branch?

@ziyi-yan
Copy link
Contributor Author

ziyi-yan commented Aug 1, 2020

@johanbrandhorst No problem! I'll do it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants