Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix slice appendings in generating field mask paths #1555

Merged
merged 1 commit into from
Jul 28, 2020
Merged

fix slice appendings in generating field mask paths #1555

merged 1 commit into from
Jul 28, 2020

Conversation

houz42
Copy link
Contributor

@houz42 houz42 commented Jul 28, 2020

References to other Issues or PRs

Fixes #1549 , back port #1553

Have you read the Contributing Guidelines?

yes

Brief description of what is fixed or changed

join field mask paths earlier in case slice appendings overwrite shared underlying array.

Other comments

@johanbrandhorst johanbrandhorst merged commit 96d8e5a into grpc-ecosystem:master Jul 28, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@houz42 houz42 deleted the fix-fieldmask-v1 branch July 28, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect field mask generated for deeply nested struct
3 participants
@houz42 @johanbrandhorst @googlebot