Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse media type for inbound marshaler #1506

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Parse media type for inbound marshaler #1506

merged 2 commits into from
Jul 7, 2020

Conversation

movsb
Copy link
Contributor

@movsb movsb commented Jul 6, 2020

References to other Issues or PRs

Fixes #1505

Have you read the Contributing Guidelines?

I've read it.

Brief description of what is fixed or changed

Parse Content-Type before querying mimeMap.

johanbrandhorst
johanbrandhorst requested changes Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add some tests for this, as you suggested 😄?

runtime/marshaler_registry.go Outdated Show resolved Hide resolved
@movsb
Copy link
Contributor Author

movsb commented Jul 7, 2020

HI, @johanbrandhorst tests added, please review again. 😊

@johanbrandhorst johanbrandhorst merged commit ed01939 into grpc-ecosystem:master Jul 7, 2020
@johanbrandhorst
Copy link
Collaborator

Thank you so much for your contribution! Could you please cherry pick this against the v2 branch?

@movsb movsb deleted the parse-media-type branch July 7, 2020 18:29
@movsb movsb mentioned this pull request Jul 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime.MarshalerForRequest: Content-Type should have been parsed before querying mimeMap
3 participants
@movsb @johanbrandhorst @googlebot