Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 8088 instead of 8080 in integration test. #1184

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

drigz
Copy link
Contributor

@drigz drigz commented Mar 23, 2020

This should avoid a failure on Bazel's Buildkite CI, where 8080 cannot be used.

This should avoid a failure on Bazel's Buildkite CI, where 8080 cannot be used.
@drigz
Copy link
Contributor Author

drigz commented Mar 23, 2020

https://buildkite.com/bazel/grpc-ecosystem-grpc-gateway/builds/331

Not sure why Buildkite doesn't post status to pull requests.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a weird error. Thanks for figuring it out!

@johanbrandhorst johanbrandhorst merged commit 5e68b7e into grpc-ecosystem:master Mar 23, 2020
@achew22
Copy link
Collaborator

achew22 commented Mar 23, 2020

@drigz, where would I file a bug to have someone look into it posting a comment on this repo?

@drigz
Copy link
Contributor Author

drigz commented Mar 23, 2020

I think the problem is a conflict with this metrics server: https://github.com/bazelbuild/continuous-integration/blob/85b2f190c32b95adc3759c2c901b2d2244aa8d2a/metrics/main.go

You could file an issue on the continuous-integration repo suggesting they switch to less commonly-used port, but I can't think of a perfect solution.

I realize now you probably meant the status feedback. https://github.com/bazelbuild/continuous-integration/issues is probably still the right place, but since the builds are already running (https://buildkite.com/bazel/grpc-ecosystem-grpc-gateway, needs login), perhaps it could be a permissions issue on this repo?

@srenatus
Copy link
Contributor

srenatus commented Apr 18, 2020

Oooh finally the streak of red builds in bazel's BK turned green. 👏 Thanks a lot for looking into this. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants