Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Bazel memory usage in CI. #1183

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

drigz
Copy link
Contributor

@drigz drigz commented Mar 23, 2020

This aims to reduce/eliminate the CircleCI flakes described in #968.
It's based on the approach in
https://github.com/angular/angular-cli/blob/master/.circleci/bazel.rc

This aims to reduce/eliminate the CircleCI flakes described in grpc-ecosystem#968.
It's based on the approach in
https://github.com/angular/angular-cli/blob/master/.circleci/bazel.rc
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks Rodrigo!

@drigz
Copy link
Contributor Author

drigz commented Mar 23, 2020

FWIW I'm not sure that this will help - bazelbuild/rules_typescript#380 suggests that the workaround wasn't sufficient in their case, and that they had to use a large instance, which requires the Performance Plan. Could be worth keeping the issue open and revisiting the next time the stale[bot] jumps in.

@johanbrandhorst johanbrandhorst merged commit d825bf0 into grpc-ecosystem:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants