nitpick spacing in other proto files #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Renatus <srenatus@chef.io>
Signed-off-by: Stephan Renatus <srenatus@chef.io>
|
Hrm running those tests locally passes. Can we re-run on circleci? |
Yeah that test is sometimes a bit flaky. Rerunning it now. |
Codecov Report
@@ Coverage Diff @@
## master #1032 +/- ##
=======================================
Coverage 53.62% 53.62%
=======================================
Files 40 40
Lines 4056 4056
=======================================
Hits 2175 2175
Misses 1675 1675
Partials 206 206Continue to review full report at Codecov.
|
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* examples/*.proto: make spaces consistent (with tabs) Signed-off-by: Stephan Renatus <srenatus@chef.io> * examples/*.proto: make spaces consistent (with tabs) [regenerate] Signed-off-by: Stephan Renatus <srenatus@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johanbrandhorst was asking for it 😉
I'm not sure why
examples/proto/examplepb/unannotated_echo_service.pb.gowasn't rebuilt, though. 🤔