Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs need type assertion on proto.Message #1026

Merged
merged 2 commits into from
Sep 3, 2019
Merged

docs need type assertion on proto.Message #1026

merged 2 commits into from
Sep 3, 2019

Conversation

zachgersh
Copy link
Contributor

makes a bit more sense with the type assertion and not using the proto.Message directly.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a small idea, feel free to reject it and I can merge this.

docs/_docs/customizingyourgateway.md Outdated Show resolved Hide resolved
Co-Authored-By: Johan Brandhorst <johan.brandhorst@gmail.com>
@johanbrandhorst
Copy link
Collaborator

Fuzzit failure is fixed on master, I'll merge this.

@johanbrandhorst johanbrandhorst merged commit 00f5cc7 into grpc-ecosystem:master Sep 3, 2019
@johanbrandhorst
Copy link
Collaborator

Thanks for the contribution!

adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
* docs need type assertion on proto.Message

* Update docs/_docs/customizingyourgateway.md

Co-Authored-By: Johan Brandhorst <johan.brandhorst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants