Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the primitive type of fields #1003

Merged
merged 5 commits into from
Aug 24, 2019

Conversation

snowzach
Copy link
Contributor

Allows you to specify a custom type in case you've altered the default json handling behavior.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@snowzach
Copy link
Contributor Author

Do I need to generate everything with bazel to make this pass CI?

@johanbrandhorst
Copy link
Collaborator

Do I need to generate everything with bazel to make this pass CI?

Yes, but there's a handy oneliner in CONTRIBUTING.md

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

Codecov Report

Merging #1003 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
- Coverage   53.45%   53.42%   -0.03%     
==========================================
  Files          40       40              
  Lines        4028     4030       +2     
==========================================
  Hits         2153     2153              
- Misses       1676     1677       +1     
- Partials      199      200       +1
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/template.go 54.17% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd2d159...b79214d. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution and careful and attentive replies to my questions, great work!

@johanbrandhorst johanbrandhorst merged commit 4ba7ec0 into grpc-ecosystem:master Aug 24, 2019
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
* Allow overriding the primitive type of fields

* Updated generated files and added a separate example for type override

* Fixed formatting

* Made logic for type override a little bit more forgiving

* Added additional files it needs to pass tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants