-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.14 breaks protoc-gen-go-json #1199
Comments
Hi Vivan, thanks for raising the issue. I'll move those packages back to the public API. Unfortunately I'm not able to make a patch release right now, so you'll have to use an older release. |
@johanbrandhorst Thanks for the very quick response! Appreciate it - i'll follow this thread for any updates when you've moved the packages back into the public namespace. |
As I mentioned, I can't make a patch release for this right now, so please use 1.13 until #1193 (comment) is resolved. |
(Unless you want to use master, which is also fine) |
That works, thank you! |
Could these packages be made public again in a future release please? I've relied on them to build a custom generator and would like to upgrade it to use the protobuf v2 libs, but I'm stuck because these packages have now been made internal. EDIT: I've created a new issue for this: #1877 |
Hi there!
After moving public packages into
internal
as part of #1146, protoc-gen-go-json is now broken because it depended on thecodegenerator
anddescriptor
packages.This is very similar to: #1161 and #1154
I think it would require moving the package back into the public namespace for the package to not be broken.
The text was updated successfully, but these errors were encountered: