Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing httprule breaks our module #1168

Closed
karelbilek opened this issue Mar 11, 2020 · 3 comments · Fixed by #1169
Closed

Missing httprule breaks our module #1168

karelbilek opened this issue Mar 11, 2020 · 3 comments · Fixed by #1169

Comments

@karelbilek
Copy link

Missing httprule in 1.14 breaks our module.

Now I see there are only a few modules on whole github that use it. One is our module here

https://github.com/gunk/gunk/blob/af47d12e8be68589435b002f60f291f380aa7ef4/docgen/parser/parser.go#L14

we generate documentation from GRPC definition and this is a bit useful.

Other use I can find is here

https://github.com/elliots/protoc-gen-twirp_swagger/blob/fda01df7c6eb134cca0579e1ce45056af36f4b1a/genswagger/template_test.go#L16

It also seems to be some kind of protobuf generator (it was actually already submitted here, but this is just in the tests).

I cannot find any other use of this module on github or elsewhere. 🤷‍♂

@johanbrandhorst
Copy link
Collaborator

Hi Karel, thanks for raising this issue, I'll move httprule back into the public API.

johanbrandhorst added a commit that referenced this issue Mar 11, 2020
johanbrandhorst added a commit that referenced this issue Mar 11, 2020
adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
pull bot pushed a commit to BuildingRobotics/grpc-gateway that referenced this issue Apr 29, 2020
@200sc
Copy link

200sc commented Nov 5, 2020

Would request leaving a note in the migration guide that this was moved back to internal for v2

@johanbrandhorst
Copy link
Collaborator

Great idea, what can I do to help you contribute that to our docs site?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants