Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jfbrandhorst/grpc-gateway-build-env image can't run on Windows #1073

Closed
someone1 opened this issue Nov 1, 2019 · 4 comments · Fixed by #1074
Closed

jfbrandhorst/grpc-gateway-build-env image can't run on Windows #1073

someone1 opened this issue Nov 1, 2019 · 4 comments · Fixed by #1074
Assignees

Comments

@someone1
Copy link
Contributor

someone1 commented Nov 1, 2019

The jfbrandhorst/grpc-gateway-build-env:1.13 image can't be pulled in a Windows docker environment:

PS C:\> docker pull jfbrandhorst/grpc-gateway-build-env:1.13
Error response from daemon: mediaType in manifest should be 'application/vnd.docker.distribution.manifest.v2+json' not ''

And running it as described in the contributing doc from a linux environment errors with:

protoc -I /usr/local/bin//../include -I. -Ithird_party/googleapis --plugin=bin/protoc-gen-swagger --swagger_out=logtostderr=true,allow_repeated_fields_in_body=true,use_go_templates=true,Mgoogle/protobuf/field_mask.proto=google.golang.org/genproto/protobuf/field_mask,Mgoogle/protobuf/descriptor.proto=github.com/golang/protobuf/protoc-gen-go/descriptor,Mexamples/proto/sub/message.proto=github.com/grpc-ecosystem/grpc-gateway/examples/proto/sub,grpc_api_configuration=examples/proto/examplepb/unannotated_echo_service.yaml:. examples/proto/examplepb/echo_service.proto examples/proto/examplepb/a_bit_of_everything.proto examples/proto/examplepb/wrappers.proto examples/proto/examplepb/stream.proto examples/proto/examplepb/unannotated_echo_service.proto examples/proto/examplepb/use_go_template.proto examples/proto/examplepb/response_body_service.proto
generate -i examples/proto/examplepb/echo_service.swagger.json \
    -l go -o examples/clients/echo --additional-properties packageName=echo
make: generate: Command not found
make: *** [Makefile:169: examples/clients/echo/client.go] Error 127

Originally posted by @someone1 in #1072 (comment)

@achew22
Copy link
Collaborator

achew22 commented Nov 1, 2019

@johanbrandhorst could I have you move this over to the other repo?

@johanbrandhorst
Copy link
Collaborator

The first error is because of a docker hub issue. I would like to move the image hosting to GitHub once the package registry is GA (13th of Nov AFAIK). The second error I'm not so sure about, but I will have a look when I have time.

@achew22 not sure what you mean by moving the image?

@johanbrandhorst johanbrandhorst self-assigned this Nov 2, 2019
@achew22
Copy link
Collaborator

achew22 commented Nov 2, 2019

Sorry, I was talking about the issue not the image. Words are hard. Please leave this until you're back and settled at home

@johanbrandhorst
Copy link
Collaborator

I've re-pushed the 1.13 image, and it should now be pullable: https://hub.docker.com/r/jfbrandhorst/grpc-gateway-build-env/tags.

I've opened a PR to fix the generation instructions: #1074. This should fix the issue. Thanks for the report @someone1. Let me know if you still have issues.

johanbrandhorst added a commit that referenced this issue Nov 3, 2019
adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants