-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
runtime: stop using nil ponters with Unmarshal
Fixes #1025
- Loading branch information
1 parent
00f5cc7
commit 2a8b7c5
Showing
2 changed files
with
155 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
package runtime_test | ||
|
||
import ( | ||
"encoding/json" | ||
"fmt" | ||
"reflect" | ||
"testing" | ||
|
||
"github.com/golang/protobuf/proto" | ||
"github.com/golang/protobuf/ptypes/duration" | ||
"github.com/golang/protobuf/ptypes/timestamp" | ||
"github.com/grpc-ecosystem/grpc-gateway/runtime" | ||
) | ||
|
||
func TestConvertTimestamp(t *testing.T) { | ||
specs := []struct { | ||
name string | ||
input string | ||
output *timestamp.Timestamp | ||
wanterr error | ||
}{ | ||
{ | ||
name: "a valid RFC3339 timestamp", | ||
input: `"2016-05-10T10:19:13.123Z"`, | ||
output: ×tamp.Timestamp{ | ||
Seconds: 1462875553, | ||
Nanos: 123000000, | ||
}, | ||
wanterr: nil, | ||
}, | ||
{ | ||
name: "invalid timestamp", | ||
input: `"05-10-2016T10:19:13.123Z"`, | ||
output: nil, | ||
wanterr: fmt.Errorf(`bad Timestamp: parsing time "05-10-2016T10:19:13.123Z" as "2006-01-02T15:04:05.999999999Z07:00": cannot parse "0-2016T10:19:13.123Z" as "2006"`), | ||
}, | ||
{ | ||
name: "JSON number", | ||
input: "123", | ||
output: nil, | ||
wanterr: &json.UnmarshalTypeError{ | ||
Value: "number", | ||
Type: reflect.TypeOf("123"), | ||
Offset: 3, | ||
}, | ||
}, | ||
{ | ||
name: "JSON bool", | ||
input: "true", | ||
output: nil, | ||
wanterr: &json.UnmarshalTypeError{ | ||
Value: "bool", | ||
Type: reflect.TypeOf("123"), | ||
Offset: 4, | ||
}, | ||
}, | ||
} | ||
|
||
for _, spec := range specs { | ||
t.Run(spec.name, func(t *testing.T) { | ||
ts, err := runtime.Timestamp(spec.input) | ||
if spec.wanterr != nil { | ||
if !reflect.DeepEqual(err, spec.wanterr) { | ||
t.Errorf("got unexpected error\n%#v\nexpected\n%#v", err, spec.wanterr) | ||
} | ||
return | ||
} | ||
if !proto.Equal(ts, spec.output) { | ||
t.Errorf( | ||
"when testing %s; got\n%#v\nexpected\n%#v", | ||
spec.name, | ||
ts, | ||
spec.output, | ||
) | ||
} | ||
}) | ||
} | ||
} | ||
|
||
func TestConvertDuration(t *testing.T) { | ||
specs := []struct { | ||
name string | ||
input string | ||
output *duration.Duration | ||
wanterr error | ||
}{ | ||
{ | ||
name: "a valid duration", | ||
input: `"123.456s"`, | ||
output: &duration.Duration{ | ||
Seconds: 123, | ||
Nanos: 456000000, | ||
}, | ||
wanterr: nil, | ||
}, | ||
{ | ||
name: "invalid duration", | ||
input: `"123years"`, | ||
output: nil, | ||
wanterr: fmt.Errorf(`bad Duration: time: unknown unit years in duration 123years`), | ||
}, | ||
{ | ||
name: "JSON number", | ||
input: "123", | ||
output: nil, | ||
wanterr: &json.UnmarshalTypeError{ | ||
Value: "number", | ||
Type: reflect.TypeOf("123"), | ||
Offset: 3, | ||
}, | ||
}, | ||
{ | ||
name: "JSON bool", | ||
input: "true", | ||
output: nil, | ||
wanterr: &json.UnmarshalTypeError{ | ||
Value: "bool", | ||
Type: reflect.TypeOf("123"), | ||
Offset: 4, | ||
}, | ||
}, | ||
} | ||
|
||
for _, spec := range specs { | ||
t.Run(spec.name, func(t *testing.T) { | ||
ts, err := runtime.Duration(spec.input) | ||
if spec.wanterr != nil { | ||
if !reflect.DeepEqual(err, spec.wanterr) { | ||
t.Errorf("got unexpected error\n%#v\nexpected\n%#v", err, spec.wanterr) | ||
} | ||
return | ||
} | ||
if !proto.Equal(ts, spec.output) { | ||
t.Errorf( | ||
"when testing %s; got\n%#v\nexpected\n%#v", | ||
spec.name, | ||
ts, | ||
spec.output, | ||
) | ||
} | ||
}) | ||
} | ||
} |