Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor start.js and update.js #26

Merged
merged 27 commits into from
Mar 20, 2024
Merged

Refactor start.js and update.js #26

merged 27 commits into from
Mar 20, 2024

Conversation

stefvanbuuren
Copy link
Member

This PR refactors start.js and update.js for clarity and succinctness, by

  • removing duplicate code
  • using ES6 JS language
  • putting long code into functions.

@stefvanbuuren
Refactor start.js
036298f
@stefvanbuuren
Refactor and split update.js
dd26c36
@stefvanbuuren
Update opencpu-0.5-james-0.1.js
d609d99
@stefvanbuuren
Add new .js file
c496d45
@stefvanbuuren
Update start.js
990c954
@stefvanbuuren
Typo
5ce2fa0
@stefvanbuuren
Use update NoticePanel
66f649e
@stefvanbuuren
Adapt toggle div behavior to new JS setup
1a7b137
@stefvanbuuren
Repair typos
ef1242c
@stefvanbuuren
Replace plotdiv --> plotDiv
ce0eb4a
@stefvanbuuren
Make binding to updateDonordata
841547a
@stefvanbuuren
Use former show/hide rules for UI elements
6a39991
@stefvanbuuren
Revert to old accordion behavior
a82253a
@stefvanbuuren
Use camelCase variables
3963a95
@stefvanbuuren
Use output.slider_list
e232e5e
@stefvanbuuren
Make toLowerCase() work
9b462d6
@stefvanbuuren
Convert output.week to string
59a3f29
@stefvanbuuren
Set correct ga for D-score
1cf14a6
@stefvanbuuren
Repair call to updateNoticePanel()
dbc48c9
@stefvanbuuren
Initialise D-score panel
d4147d7
@stefvanbuuren
Remove typo
9afd7a4
@stefvanbuuren
Restore collapse behavior
a786094
@stefvanbuuren
As string function instead of method
2c51585
@stefvanbuuren
Remove rogue code
a29b031
@stefvanbuuren
Update version date
8541725
@stefvanbuuren
Update version date
ebed700
@stefvanbuuren
Merge branch 'master' into refactorJS
3c0f68a
@stefvanbuuren stefvanbuuren merged commit fafb23e into master Mar 20, 2024
0 of 5 checks passed
@stefvanbuuren stefvanbuuren deleted the refactorJS branch March 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stefvanbuuren