Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect version number in "Meldingen" panel #32

Closed
stefvanbuuren opened this issue May 7, 2024 · 1 comment
Closed

Incorrect version number in "Meldingen" panel #32

stefvanbuuren opened this issue May 7, 2024 · 1 comment
Assignees
@stefvanbuuren
Labels
bug Something isn't working

Comments

@stefvanbuuren
Copy link
Member

The version number displayed in the documentation of https://james.groeidiagrammen.nl is currently 1.6.0. The version number displayed in "Meldingen" panel of https://james.groeidiagrammen.nl/site is currently JAMES 1.5.9 (20240321), © TNO 2024.

Clearly, these should always be the same and be synchronised with the version endpoint (which displays the james R package version used for building the app). Preferably, all version changes should be automated.
@stefvanbuuren stefvanbuuren added the bug Something isn't working label May 7, 2024
@stefvanbuuren stefvanbuuren self-assigned this May 7, 2024
stefvanbuuren added a commit that referenced this issue May 8, 2024
@stefvanbuuren
Add helper update_version_files() that reads version number from DESC…
bc9324c 
…RIPTION and updates vignettes/articles/getting_started.Rmd and inst/www/index.html #32
@stefvanbuuren
Copy link
Member Author

Problem was resolved in james 1.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefvanbuuren stefvanbuuren

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefvanbuuren