Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to duplicate/archive fact metrics & archive fact tables #2911

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

msamper
Copy link
Contributor

@msamper msamper commented Aug 21, 2024

Features and Changes

Allows users to duplicate/archive fact metrics and archive fact tables. For duplicating fact metrics we're only allowing users to do it within its parent fact table and not in the overall metrics list. I felt like it would be a weird UX to allow duplication from that overall list.

Testing

  1. Create a few fact tables with metrics
  2. Archive some of the fact tables and make sure their associated fact metrics don't show up as potential metrics for experiments.
  3. Make sure the show archived toggles work as expected
  4. Try archiving metrics within a fact table
  5. Archive and unarchive a fact table with some archived metrics and make sure their archived state remains the same

Screenshots

To-Do

  • Show which metrics have been archived within a Fact Table page

Copy link

github-actions bot commented Aug 21, 2024

Your preview environment pr-2911-bttf has been deployed.

Preview environment endpoints are available at:

@msamper msamper changed the title [WIP] Make it possible to duplicate/archive fact metrics Make it possible to duplicate/archive fact metrics & archive fact tables Sep 16, 2024
@msamper msamper merged commit 2f42487 into main Sep 17, 2024
3 checks passed
@msamper msamper deleted the msamper/dupe-fact-metrics branch September 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants