Make owner optional in experiment POST endpoint. #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-growthbook
force-pushed
the
romain/optional-experiment-owner
branch
from
0f0f02b
to
b0bb472
Compare
|
Deploy preview for docs ready! ✅ Preview Built with commit 170ccd3. |
romain-growthbook
force-pushed
the
romain/optional-experiment-owner
branch
from
b0bb472
to
3fea430
Compare
| @@ -47,20 +47,26 @@ export const postExperiment = createApiRequestHandler(postExperimentValidator)( | |||
| ); | |||
| } | |||
|
|
|||
| const user = await getUserByEmail(owner); | |||
| const ownerId = await (async () => { | |||
| if (!onwerEmail) return req.context.userId; | |||
There was a problem hiding this comment.
The original feature request specification is:
if the auth was done via a personal access token, and an owner property wasn't provided, we should default to the owner of the personal access token.
Is that the right interpretation?
romain-growthbook
force-pushed
the
romain/optional-experiment-owner
branch
from
3fea430
to
f194e5d
Compare
|
Your preview environment pr-2133-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
reviewed
Feb 16, 2024
when available and owner is not provided.
romain-growthbook
force-pushed
the
romain/optional-experiment-owner
branch
from
f194e5d
to
170ccd3
Compare
jdorn
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
This PR addresses the changes described in #1928. It makes
ownerbody argument optional and uses the request'suserIdfor its value when available and noownerhas been spericified.