Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle US Bank payment option #2070

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Handle US Bank payment option #2070

merged 1 commit into from
Feb 2, 2024

Conversation

tzjames
Copy link
Collaborator

@tzjames tzjames commented Jan 26, 2024

Features and Changes

On our Stripe billing page we accept US bank accounts. https://dashboard.stripe.com/settings/billing/invoice?tab=general
We have it selected to also accept Sepa direct debit and ACH direct debit but they don't show up.
On the checkout page we were only allowing credit cards.
On our /settings/billing page we warning people that they need to enter a payment option even when they had a bank payment option set up.

  • Allows banks on the checkout page
  • Shows the missing payment warning only when they have no payment option set, regardless of payment method.

Testing

Set IS_CLOUD=true in .env.local for both front-end and back-end.
Set STRIPE_SECRET and STRIPE_PRICE to be the test secret and test price.
Start the server.
In mongo set "freeTrialDate" on the organization.
Click "Try Pro".
Click the button to buy.
See the bank option.
Pay by bank.
Click return to Growthbook
Go to http://localhost:3000/settings/billing and see that it says "You have a valid payment method on file. You will be billed automatically on this date."

Copy link

Your preview environment pr-2070-bttf has been deployed with errors.

Copy link
Collaborator

@mknowlton89 mknowlton89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything worked as expected.

@tzjames tzjames merged commit a1c63b8 into main Feb 2, 2024
2 of 3 checks passed
@tzjames tzjames deleted the ji/hasPaymentMethod branch February 2, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants