Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Snowflake Warehouse setting to optional #1764

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

lukesonnet
Copy link
Collaborator

Features and Changes

The snowflake-promise connector doesn't require a warehouse and Snowflake is happy to default to the default warehouse for a user you specify if there isn't one in the connected client.

Therefore, specifying warehouse is unnecessary.

This makes it optional.

Testing

I can save this form as is, which runs a test query:

image

I also can run the experiment assignment test query which actually requires a warehouse:
Screenshot 2023-10-18 at 11 07 45 AM

Evidence it set the warehouse:
Screenshot 2023-10-18 at 11 08 33 AM

@lukesonnet lukesonnet requested a review from jdorn October 18, 2023 17:09
@github-actions
Copy link

Your preview environment pr-1764-bttf has been deployed.

Preview environment endpoints are available at:

@lukesonnet lukesonnet merged commit ce30d6d into main Oct 18, 2023
3 checks passed
@lukesonnet lukesonnet deleted the ls/snowflake_warehouse_opt branch October 18, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants