Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cascader use keyboard nav #579

Merged
merged 8 commits into from
Dec 4, 2020
Merged

feat: cascader use keyboard nav #579

merged 8 commits into from
Dec 4, 2020

Conversation

iahu
Copy link
Contributor

@iahu iahu commented Dec 3, 2020

支持键盘控制

@vercel
Copy link

vercel bot commented Dec 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/g8zsi8hob
✅ Preview: https://gio-design-git-cascader-keyboard-nav.growingio.vercel.app

@iahu iahu requested review from zzt1224 and WORLDI and removed request for zzt1224 December 3, 2020 12:14
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #579 (cabee57) into master (f819828) will decrease coverage by 0.36%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   79.52%   79.16%   -0.37%     
==========================================
  Files         126      126              
  Lines        4084     4156      +72     
  Branches     1072     1091      +19     
==========================================
+ Hits         3248     3290      +42     
- Misses        830      860      +30     
  Partials        6        6              
Impacted Files Coverage Δ
...kages/components/src/components/cascader/helper.ts 66.25% <41.30%> (-33.75%) ⬇️
...s/components/src/components/cascader/menu-item.tsx 92.13% <75.00%> (-2.06%) ⬇️
...components/src/components/cascader/single-menu.tsx 91.52% <78.57%> (-1.46%) ⬇️
...ckages/components/src/components/cascader/menu.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6284897...e34ca4d. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@jack0pan jack0pan merged commit c4f9ea9 into growingio:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants