Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): add border-radius to table when placeholder #569

Merged
merged 3 commits into from
Dec 4, 2020
Merged

fix(table): add border-radius to table when placeholder #569

merged 3 commits into from
Dec 4, 2020

Conversation

WORLDI
Copy link
Contributor

@WORLDI WORLDI commented Dec 2, 2020

affects: @gio-design/components, website

add border-radius to table when placeholder

@gio-design/components, website@20.11.5

  • 列表
    • 解决table在placeholder情况时左上角和右上角圆角边框缺失的问题
  • 警告提示
    • 去掉 .gio-alert上的margin样式
  • 输入框
    • 定义输入框disabled情况下文字的颜色
  • 导航菜单
    • <Menu>下子元素的间距问题

@gio-design/components, website@20.11.5

  • table
    • To solve the problem that the top left corner and the top right corner of the table are missing when the table is in the placeholder case
  • alert
    • Remove the margin style on .gio-alert
  • input
    • Define the color of the text when the input box is disabled
  • Menu
    • fix the gap of Menu's children

@vercel
Copy link

vercel bot commented Dec 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/3d9mxwwwo
✅ Preview: https://gio-design-git-issuesfifth.growingio.vercel.app

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #569 (e2884e1) into master (f819828) will decrease coverage by 0.36%.
The diff coverage is 65.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
- Coverage   79.52%   79.16%   -0.37%     
==========================================
  Files         126      126              
  Lines        4084     4156      +72     
  Branches     1072     1091      +19     
==========================================
+ Hits         3248     3290      +42     
- Misses        830      860      +30     
  Partials        6        6              
Impacted Files Coverage Δ
...ckages/components/src/components/menu/MenuItem.tsx 93.33% <0.00%> (ø)
...kages/components/src/components/cascader/helper.ts 66.25% <41.30%> (-33.75%) ⬇️
...s/components/src/components/cascader/menu-item.tsx 92.13% <75.00%> (-2.06%) ⬇️
...components/src/components/cascader/single-menu.tsx 91.52% <78.57%> (-1.46%) ⬇️
...ckages/components/src/components/cascader/menu.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f9ea9...01f7c1d. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-569--gio-design.surge.sh

@WORLDI WORLDI requested a review from LEEHONCN December 2, 2020 05:09
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

affects: @gio-design/components, website

add border-radius to table when placeholder
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@jack0pan jack0pan merged commit f3dbab9 into growingio:master Dec 4, 2020
@WORLDI WORLDI deleted the issues_fifth branch December 22, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants