Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): datasource prop should always be controlled #493

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix(list): datasource prop should always be controlled #493

merged 2 commits into from
Nov 24, 2020

Conversation

LEEHONCN
Copy link
Contributor

affects: @gio-design/components, website

ISSUES CLOSED: #250

@gio-design/components@20.11.3

  • 列表
    • dataSource 参数应该总是受控的

@gio-design/components@20.11.3

  • List
    • datasource prop should always be controlled

affects: @gio-design/components, website

ISSUES CLOSED: #250
@vercel
Copy link

vercel bot commented Nov 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/dzayfyq3i
✅ Preview: https://gio-design-git-list-add.growingio.vercel.app

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@180b19a). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #493   +/-   ##
=========================================
  Coverage          ?   74.67%           
=========================================
  Files             ?      120           
  Lines             ?     3013           
  Branches          ?      923           
=========================================
  Hits              ?     2250           
  Misses            ?      759           
  Partials          ?        4           
Impacted Files Coverage Δ
packages/components/src/components/list/core.tsx 88.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180b19a...902a606. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-493--gio-design.surge.sh

@LEEHONCN LEEHONCN requested a review from gh2049 November 20, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[List] 不提供value参数时 dataSource prop 不受控。
3 participants