Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fix trigger disabled bug #465

Merged
merged 1 commit into from
Nov 13, 2020
Merged

fix(tooltip): fix trigger disabled bug #465

merged 1 commit into from
Nov 13, 2020

Conversation

LEEHONCN
Copy link
Contributor

affects: @gio-design/components

@gio-design/components@20.11.1

  • 文字提示
    • disabled 状态下不应该改变内部visible状态

@gio-design/components@20.11.1

  • Tooltip
    • should not update internal state when tooltip disabled

@vercel
Copy link

vercel bot commented Nov 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/growingio/gio-design/3t54x6lkh
✅ Preview: https://gio-design-git-tooltip-fix.growingio.vercel.app

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #465 (56315e0) into master (80d1d59) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   76.93%   76.95%   +0.01%     
==========================================
  Files         114      114              
  Lines        3690     3692       +2     
  Branches      881      882       +1     
==========================================
+ Hits         2839     2841       +2     
  Misses        845      845              
  Partials        6        6              
Impacted Files Coverage Δ
...ages/components/src/components/tooltip/Tooltip.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d1d59...9af0339. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-465--gio-design.surge.sh

affects: @gio-design/components
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-465--gio-design.surge.sh

@gavin-hao gavin-hao merged commit 8ba0426 into growingio:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants