Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): fix the problem that destructing the rest may overwrite value field,and update input document #458

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

HunterGitHub
Copy link
Contributor

@gio-design/package

  • Input
    • 修复 rest 解构覆盖value属性的问题
    • input 文档更新同步

@HunterGitHub HunterGitHub changed the title fix(Input): fix the problem that destructing the rest may overwrite value field,and update input document fix(input): fix the problem that destructing the rest may overwrite value field,and update input document Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #458 (3db87ad) into master (c2c3c64) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         111      111           
  Lines        3622     3622           
  Branches      863      863           
=======================================
  Hits         2799     2799           
  Misses        818      818           
  Partials        5        5           
Impacted Files Coverage Δ
packages/components/src/components/input/Input.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c3c64...1c207d7. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-458--gio-design.surge.sh

@gavin-hao gavin-hao requested a review from LEEHONCN November 10, 2020 11:36
@gavin-hao gavin-hao merged commit 8b21f93 into growingio:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants