Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): define dropdown interaction #450

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix(dropdown): define dropdown interaction #450

merged 1 commit into from
Nov 10, 2020

Conversation

LEEHONCN
Copy link
Contributor

affects: @gio-design/components

@gio-design/components@20.11.1

  • 下拉框
    • 定义交互逻辑,当未传visible参数点击overlay区域会关闭下拉框。

@gio-design/components@20.11.1

  • Dropdown
    • define dropdown interaction, it will be close after click the overlay area without visible.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-450--gio-design.surge.sh

affects: @gio-design/components
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #450 (c1fc343) into master (9e6373b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   77.32%   77.32%           
=======================================
  Files         111      111           
  Lines        3630     3630           
  Branches      863      864    +1     
=======================================
  Hits         2807     2807           
  Misses        818      818           
  Partials        5        5           
Impacted Files Coverage Δ
...es/components/src/components/dropdown/Dropdown.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6373b...b7632f0. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-450--gio-design.surge.sh

@LEEHONCN LEEHONCN requested a review from zzt1224 November 10, 2020 08:14
@gavin-hao gavin-hao assigned gavin-hao and unassigned gavin-hao Nov 10, 2020
@gavin-hao gavin-hao merged commit 711b2d6 into growingio:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants