Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): fix internal className will be cover #431

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix(input): fix internal className will be cover #431

merged 1 commit into from
Nov 10, 2020

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN commented Nov 6, 2020

affects: @gio-design/components

@gio-design/components@20.11.1

  • 输入框
    • 修复组件内的className会被覆盖

@gio-design/components@20.11.1

  • Input
    • fix internal className will be cover

@LEEHONCN LEEHONCN requested review from zzt1224 and itiiss November 6, 2020 07:29
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #431 (b560850) into master (9e6373b) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   77.32%   77.27%   -0.06%     
==========================================
  Files         111      111              
  Lines        3630     3622       -8     
  Branches      863      863              
==========================================
- Hits         2807     2799       -8     
  Misses        818      818              
  Partials        5        5              
Impacted Files Coverage Δ
...omponents/src/components/pagination/Pagination.tsx 98.76% <ø> (ø)
...ckages/components/src/components/select/Select.tsx 97.12% <ø> (ø)
packages/components/src/components/input/Input.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6373b...e2661a0. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-431--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-431--gio-design.surge.sh

affects: @gio-design/components
@LEEHONCN LEEHONCN merged commit c2c3c64 into growingio:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Input] Input 未对传入的className进行合并,而是直接覆盖了
3 participants