[feat]: add gio-grid component #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @gio-design/components, website
|
Deploy preview for gio-design failed. |
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
+ Coverage 57.62% 57.82% +0.20%
==========================================
Files 105 106 +1
Lines 3325 3341 +16
Branches 805 806 +1
==========================================
+ Hits 1916 1932 +16
Misses 1405 1405
Partials 4 4
Continue to review full report at Codecov.
|
|
Deploy preview for ready! ✅ https://deploy-preview-338--gio-design.surge.sh |
|
Deploy preview for ready! ✅ https://deploy-preview-338--gio-design.surge.sh |
phyzess
reviewed
Oct 23, 2020
|
|
||
| ## API | ||
|
|
||
| ### Input |
|
Deploy preview for gio-design failed. |
* update: style * chore: time-picker * fix: clear log Co-authored-by: chen_gh <chenguanghao@growingio.com>
affects: @gio-design/components
…295) affects: @gio-design/components
affects: @gio-design/components, website add rangePicker adds a new parameter for the renderExtraFooter method to return a React.ReactNode to add a custion footer.fix rangePicker change the date or the date displayed in the year does not change. fix rangePicker onSelect method is invalid
* docs: @gio-design/components 20.10.0 change log * docs: @gio-design/components 20.10.0 change log
affects: @gio-design/components, @gio-design/icons, @gio-design/tokens, website fix changelog and version numbers;
affects: @gio-design/components, @gio-design/icons, website
affects: website
Co-authored-by: chen_gh <chenguanghao@growingio.com>
affects: @gio-design/components, website daa dateRangePicker disabledDate methods and fix props.value change is not change Input value ISSUES CLOSED: #304
* fix: allow use value control selections; affects: @gio-design/components, website * fix: fix type bug affects: @gio-design/components * fix: modify defaultSelection as default value of defaultValue affects: @gio-design/components
affects: @gio-design/components 根据stylelint的提示，修改了form组件中index.less中部分属性的顺序
* fix: fix overflow text elips affects: @gio-design/components * fix: add iconns affects: @gio-design/icons
affects: @gio-design/components, @gio-design/icons, website
affects: @gio-design/components, @gio-design/icons, website replace 20.10.3 empty package
affects: @gio-design/components, website
affects: @gio-design/components, website Upload组件增加一个可选参数isBorder，控制图片上传成功后边框是否显示，默认为false
…333) affects: @gio-design/components, website 修复Dropdown组件中placement方向的问题，由12个方向改为只有上下6个方向可选，默认方向为下
affects: @gio-design/components 定义了select组件中input选择框内的文字尺寸
affects: @gio-design/components Unit test of alert component is added
* fix(components): change folder name from camel case to kebab case affects: @gio-design/components * fix(components): fix tab-nav folder name affects: @gio-design/components, website
|
Deploy preview for ready! ✅ https://deploy-preview-338--gio-design.surge.sh |
phyzess
approved these changes
Oct 26, 2020
zzt1224
approved these changes
Oct 26, 2020
| return Math.max(min, Math.min(max, value)); | ||
| }; | ||
|
|
||
| export const isNumber = <T = unknown>(n: T): boolean => typeof n === 'number'; |
There was a problem hiding this comment.
有个isFinite可以判断非Nan和infinity的数字
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add gio-grid component