Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip #31

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Tooltip #31

merged 5 commits into from
Jul 21, 2020

Conversation

LEEHONCN
Copy link
Contributor

No description provided.

lihang added 2 commits July 20, 2020 14:21
affects: @gio-design/components, website
@netlify
Copy link

netlify bot commented Jul 20, 2020

Deploy preview for gio-design ready!

Built with commit fc6b207

https://deploy-preview-31--gio-design.netlify.app

affects: @gio-design/components
@LEEHONCN LEEHONCN requested review from jack0pan and phyzess July 21, 2020 01:50
@jack0pan jack0pan removed their request for review July 21, 2020 05:52
Copy link
Contributor

@phyzess phyzess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • demo 里面关于tooltipLink的独立 demo 增加一个是不是更好点?包括这个属性的解释文字:默认这个配置了之后会出现在哪儿,是否可以只配置 tooltipLink 不写title 等等
  • 参数说明里面 placement 的可选项需要补充一下
    其他的没啥问题应该,上面的你参考一下

lihang added 2 commits July 21, 2020 15:31
affects: @gio-design/components, website
@jack0pan jack0pan merged commit 0143e78 into growingio:master Jul 21, 2020
@LEEHONCN LEEHONCN deleted the tooltip branch July 30, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants