Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add getContainer prop #291

Merged
merged 1 commit into from
Oct 10, 2020
Merged

feat(select): add getContainer prop #291

merged 1 commit into from
Oct 10, 2020

Conversation

LEEHONCN
Copy link
Contributor

affects: @gio-design/components, website

Related issue link

Changelog

Language Changelog
🇺🇸 English add getContainer prop
🇨🇳 Chinese 添加 getContainer 参数

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components, website
@LEEHONCN LEEHONCN requested a review from zzt1224 October 10, 2020 06:02
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   64.25%   64.25%           
=======================================
  Files         100      100           
  Lines        2907     2907           
  Branches      738      696   -42     
=======================================
  Hits         1868     1868           
- Misses       1034     1035    +1     
+ Partials        5        4    -1     
Impacted Files Coverage Δ
...ckages/components/src/components/select/Select.tsx 0.00% <ø> (ø)
...ages/components/src/components/modal/StepModal.tsx 72.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ecfef...5ad96f2. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-291--gio-design.surge.sh

@zzt1224 zzt1224 merged commit 5a50832 into growingio:master Oct 10, 2020
@LEEHONCN LEEHONCN deleted the fix branch November 4, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants