Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update MenuItem title #284

Merged
merged 1 commit into from
Oct 10, 2020
Merged

refactor: update MenuItem title #284

merged 1 commit into from
Oct 10, 2020

Conversation

phyzess
Copy link
Contributor

@phyzess phyzess commented Sep 30, 2020

affects: @gio-design/components

Related issue link

#283

Changelog

Language Changelog
🇺🇸 English won't wrap children in MenuItem when there is no icon.
🇨🇳 Chinese 无 icon 的 MenuItem 不再添加 span 进行包裹 。

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components
@phyzess phyzess linked an issue Sep 30, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #284 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   64.25%   64.27%   +0.01%     
==========================================
  Files         100      100              
  Lines        2907     2908       +1     
  Branches      738      739       +1     
==========================================
+ Hits         1868     1869       +1     
  Misses       1034     1034              
  Partials        5        5              
Impacted Files Coverage Δ
...kages/components/src/components/menu/MenuTitle.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ecfef...b59dbb8. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-284--gio-design.surge.sh

@zzt1224 zzt1224 merged commit 32bd2a9 into growingio:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Menu] span 这一层能不能去掉?
3 participants