Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix link type error #262

Merged
merged 1 commit into from
Sep 27, 2020
Merged

fix: fix link type error #262

merged 1 commit into from
Sep 27, 2020

Conversation

phyzess
Copy link
Contributor

@phyzess phyzess commented Sep 25, 2020

affects: @gio-design/components

Related issue link

Changelog

Language Changelog
🇺🇸 English Fix type error in Link component
🇨🇳 Chinese 修复 Link 组件中的类型问题

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

affects: @gio-design/components
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files          94       94           
  Lines        2756     2756           
  Branches      687      687           
=======================================
  Hits         1725     1725           
  Misses       1027     1027           
  Partials        4        4           
Impacted Files Coverage Δ
packages/components/src/utils/type.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe82a7...ff63fa8. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-262--gio-design.surge.sh

@LEEHONCN LEEHONCN merged commit f19b013 into growingio:master Sep 27, 2020
@phyzess phyzess deleted the fix-link-type branch November 2, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants