Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): auto close after click overlay element #252

Merged
merged 1 commit into from
Sep 25, 2020
Merged

fix(dropdown): auto close after click overlay element #252

merged 1 commit into from
Sep 25, 2020

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN commented Sep 24, 2020

affects: @gio-design/components, website

Related issue link

Changelog

auto close after click overlay element.
change overlay type from ReactNode to ReactElement.

Language Changelog
🇺🇸 English auto close after click overlay element. change overlay type from ReactNode to ReactElement.
🇨🇳 Chinese 点击overlay元素后,自动关闭下拉菜单。将overlay的类型从ReactNode更改为ReactElement

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components, website
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #252 into master will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   62.96%   62.96%   -0.01%     
==========================================
  Files          95       95              
  Lines        2762     2770       +8     
  Branches      686      689       +3     
==========================================
+ Hits         1739     1744       +5     
- Misses       1019     1022       +3     
  Partials        4        4              
Impacted Files Coverage Δ
...ckages/components/src/components/select/Select.tsx 0.00% <0.00%> (ø)
...es/components/src/components/dropdown/Dropdown.tsx 91.66% <75.00%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b2fd4...1658c30. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-252--gio-design.surge.sh

@Danny548326 Danny548326 requested a review from itiiss September 25, 2020 08:39
@Danny548326 Danny548326 merged commit 4fe82a7 into growingio:master Sep 25, 2020
@LEEHONCN LEEHONCN deleted the dropdown-add branch November 4, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants