feat(table): add some prop to table #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
- Coverage 70.10% 70.02% -0.08%
==========================================
Files 90 90
Lines 2378 2392 +14
Branches 606 611 +5
==========================================
+ Hits 1667 1675 +8
- Misses 707 713 +6
Partials 4 4
Continue to review full report at Codecov.
|
|
Deploy preview for ready! ✅ https://deploy-preview-203--gio-design.surge.sh |
1 similar comment
|
Deploy preview for ready! ✅ https://deploy-preview-203--gio-design.surge.sh |
phyzess
requested review from
jack0pan and
huskylengcb
and removed request for
jack0pan
huskylengcb
approved these changes
Sep 15, 2020
|
Deploy preview for gio-design failed. |
affects: @gio-design/components, website
|
Deploy preview for ready! ✅ https://deploy-preview-203--gio-design.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @gio-design/components, website
add rowKey, rowClassName, onRow, onHeaderRow, showHover, showHeader prop to table.
add className, onHeaderCell prop to column.
refacter style file.
key is not must set, it default use dataIndex or index.
Related issue link
Changelog
add rowKey, rowClassName, onRow, onHeaderRow, showHover, showHeader prop to table.
add className, onHeaderCell prop to column.
key is not must set, it default use dataIndex or index.
Self check