Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): add DatePicker #199

Merged
merged 10 commits into from
Sep 17, 2020
Merged

feat(components): add DatePicker #199

merged 10 commits into from
Sep 17, 2020

Conversation

itiiss
Copy link
Contributor

@itiiss itiiss commented Sep 9, 2020 •
edited
Loading

Related issue link

Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English add DatePicker Component
πŸ‡¨πŸ‡³ Chinese 咞加ζ—₯ζœŸι€‰ζ‹©ε™¨

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@itiiss itiiss changed the title Date picker feat(components): add DatePicker Sep 10, 2020
@1eeing 1eeing requested review from phyzess, LEEHONCN and jack0pan and removed request for phyzess September 10, 2020 03:46
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for ready! βœ… https://deploy-preview-199--gio-design.surge.sh

@codecov
Copy link

codecov bot commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #199 into master will decrease coverage by 0.81%.
The diff coverage is 43.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   63.76%   62.94%   -0.82%     
==========================================
  Files          93       95       +2     
  Lines        2641     2761     +120     
  Branches      671      682      +11     
==========================================
+ Hits         1684     1738      +54     
- Misses        953     1019      +66     
  Partials        4        4
Impacted Files Coverage Ξ”
...nts/src/components/date-picker/dateRangePicker.tsx 18.18% <18.18%> (ΓΈ)
...mponents/src/components/date-picker/datePicker.tsx 74.07% <74.07%> (ΓΈ)
...components/src/components/input/hooks/useEnter.tsx 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update cb4b38f...e7211db. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! βœ… https://deploy-preview-199--gio-design.surge.sh

2 similar comments
@azure-pipelines
Copy link

Deploy preview for ready! βœ… https://deploy-preview-199--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! βœ… https://deploy-preview-199--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for ready! βœ… https://deploy-preview-199--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! βœ… https://deploy-preview-199--gio-design.surge.sh

@phyzess phyzess merged commit 4779d30 into growingio:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LEEHONCN LEEHONCN LEEHONCN approved these changes

@jack0pan jack0pan Awaiting requested review from jack0pan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itiiss @LEEHONCN @phyzess