Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list component #178

Merged
merged 1 commit into from
Sep 10, 2020
Merged

feat: list component #178

merged 1 commit into from
Sep 10, 2020

Conversation

gh2049
Copy link
Contributor

@gh2049 gh2049 commented Sep 2, 2020

Related issue link

Changelog

Language Changelog
🇺🇸 English list component
🇨🇳 Chinese 列表组件

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-178--gio-design.surge.sh

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #178 into master will decrease coverage by 3.23%.
The diff coverage is 40.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   70.68%   67.44%   -3.24%     
==========================================
  Files          77       89      +12     
  Lines        1968     2356     +388     
  Branches      514      602      +88     
==========================================
+ Hits         1391     1589     +198     
- Misses        572      762     +190     
  Partials        5        5              
Impacted Files Coverage Δ
packages/components/src/components/alert/alert.tsx 0.00% <0.00%> (ø)
...es/components/src/components/checkbox/checkbox.tsx 100.00% <ø> (ø)
packages/components/src/components/list/Group.tsx 0.00% <0.00%> (ø)
...ents/src/components/list/Sortable/SortableItem.tsx 0.00% <0.00%> (ø)
...mponents/src/components/list/Sortable/template.tsx 0.00% <0.00%> (ø)
packages/components/src/components/list/core.tsx 0.00% <0.00%> (ø)
packages/components/src/components/list/drag.tsx 0.00% <0.00%> (ø)
packages/components/src/components/list/list.tsx 0.00% <0.00%> (ø)
packages/components/src/components/list/normal.tsx 0.00% <0.00%> (ø)
packages/components/src/components/list/option.tsx 0.00% <0.00%> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5307cf...c041c85. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-178--gio-design.surge.sh

@gh2049 gh2049 requested a review from zzt1224 September 7, 2020 01:22
@gh2049 gh2049 force-pushed the list branch 2 times, most recently from 6d90b07 to 954772f Compare September 9, 2020 04:05
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-178--gio-design.surge.sh

@gh2049 gh2049 force-pushed the list branch 2 times, most recently from a648464 to dbe250f Compare September 10, 2020 06:45
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-178--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-178--gio-design.surge.sh

labelRenderer,
rowHeight,
} = this.props;
if (this.state.options && this.state.options.length) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.state?.options?.length

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@1eeing 1eeing merged commit 53708d9 into growingio:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants