Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add modal dialog component #137

Merged
merged 3 commits into from
Aug 21, 2020
Merged

feat(components): add modal dialog component #137

merged 3 commits into from
Aug 21, 2020

Conversation

phyzess
Copy link
Contributor

@phyzess phyzess commented Aug 20, 2020

affects: @gio-design/components, website

affects: @gio-design/components, website
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-137--gio-design.surge.sh

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #137 into master will decrease coverage by 4.81%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   66.28%   61.46%   -4.82%     
==========================================
  Files          67       72       +5     
  Lines        1735     1871     +136     
  Branches      453      488      +35     
==========================================
  Hits         1150     1150              
- Misses        582      717     +135     
- Partials        3        4       +1     
Impacted Files Coverage Δ
...ackages/components/src/components/modal/Footer.tsx 0.00% <0.00%> (ø)
packages/components/src/components/modal/Modal.tsx 0.00% <0.00%> (ø)
...es/components/src/components/modal/ModalContext.ts 0.00% <0.00%> (ø)
...ages/components/src/components/modal/StepModal.tsx 0.00% <0.00%> (ø)
packages/components/src/components/modal/Title.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c044324...4bf5c92. Read the comment docs.

affects: @gio-design/components, website
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-137--gio-design.surge.sh

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-137--gio-design.surge.sh

@huskylengcb huskylengcb merged commit 97e22c1 into growingio:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants