Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): refact tabs and add activeKey defaultActiveKey prop #134

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

LEEHONCN
Copy link
Contributor

No description provided.

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

1 similar comment
@azure-pipelines
Copy link

Deploy preview for gio-design failed.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-134--gio-design.surge.sh

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #134 into master will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   66.28%   66.60%   +0.32%     
==========================================
  Files          67       67              
  Lines        1735     1752      +17     
  Branches      453      459       +6     
==========================================
+ Hits         1150     1167      +17     
  Misses        582      582              
  Partials        3        3              
Impacted Files Coverage Δ
...ackages/components/src/components/tabs/TabPane.tsx 100.00% <100.00%> (ø)
packages/components/src/components/tabs/Tabs.tsx 97.43% <100.00%> (+2.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c044324...7d67743. Read the comment docs.

affects: @gio-design/components

ISSUES CLOSED: #107
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-134--gio-design.surge.sh

affects: @gio-design/components, website

ISSUES CLOSED: #111
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-134--gio-design.surge.sh

@huskylengcb huskylengcb requested review from itiiss and phyzess August 21, 2020 07:23
@huskylengcb huskylengcb merged commit 24ce9e2 into growingio:master Aug 21, 2020
@huskylengcb huskylengcb added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code and removed dependencies Pull requests that update a dependency file labels Aug 21, 2020
@LEEHONCN LEEHONCN deleted the tabs branch August 21, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants