Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components,website): 重构Breadcrumb #132

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

huskylengcb
Copy link
Contributor

affects: @gio-design/components, website

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #132 into master will decrease coverage by 0.23%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   64.06%   63.83%   -0.24%     
==========================================
  Files          60       60              
  Lines        1511     1529      +18     
  Branches      406      409       +3     
==========================================
+ Hits          968      976       +8     
- Misses        540      550      +10     
  Partials        3        3              
Impacted Files Coverage Δ
...omponents/src/components/breadcrumb/Breadcrumb.tsx 0.00% <0.00%> (ø)
...nents/src/components/breadcrumb/BreadcrumbItem.tsx 0.00% <0.00%> (ø)
.../src/components/breadcrumb/BreadcrumbSeparator.tsx 0.00% <ø> (ø)
...ckages/components/src/components/button/button.tsx 84.44% <ø> (+0.57%) ⬆️
...omponents/src/components/pagination/Pagination.tsx 82.97% <100.00%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6467661...df27b8f. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-132--gio-design.surge.sh

import '@gio-design/components/es/components/breadcrumb/style/css.js';

export default () => {
const routes = [
{
path: 'index',
path: 'components',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path是否考虑加个#不会跳转到demo别的页面

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以

affects: @gio-design/components, website
@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-132--gio-design.surge.sh

@jack0pan
Copy link
Member

jack0pan commented Aug 20, 2020

@huskylengcb

  1. 补充测试,不要让测试覆盖率掉下来。
  2. 把组件的 interface 都放到 interface.ts 文件,参考 Avatar 组件。

@huskylengcb huskylengcb merged commit f370141 into growingio:master Aug 21, 2020
@huskylengcb huskylengcb added add to next version 🐛 bug Something isn't working labels Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants