Skip to content

Commit

Permalink
chore: change ui review order in ci workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
jack0pan authored Nov 12, 2020
1 parent 925721a commit 38ea6d0
Showing 1 changed file with 30 additions and 12 deletions.
42 changes: 30 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,35 @@ jobs:
run: yarn lint:style
- name: ESLint
run: yarn lint:components
review:
name: UI Review
if: ${{ !(startsWith(github.event.pull_request.title, 'chore') || startsWith(github.event.pull_request.title, 'docs')) }}
needs: [install]
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Setup Node.js
uses: actions/setup-node@v2.1.2
with:
node-version: 12.x
- name: Restore Node.js modules
uses: actions/cache@v2
with:
path: |
node_modules
*/*/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- name: Build Storybook
run: yarn build-storybook
- name: Upload to Chromatic
uses: chromaui/action@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
projectToken: no8vpz82l1j
storybookBuildDir: packages/components/storybook-static/
build:
name: Build Packages
needs: install
Expand Down Expand Up @@ -145,15 +174,4 @@ jobs:
uses: codecov/codecov-action@v1
with:
directory: ./packages/components/coverage/
review:
name: UI Review
if: ${{ !(startsWith(github.event.pull_request.title, 'chore') || startsWith(github.event.pull_request.title, 'docs')) }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: chromaui/action@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
projectToken: no8vpz82l1j

1 comment on commit 38ea6d0

@vercel
Copy link

@vercel vercel bot commented on 38ea6d0 Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.