Customizable grid-extras-port in nodes #385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an issue reported in #284 and some other issues, where if the Grid Extras is listening in the port 3000, the node is expected to be listening on the same port.
This is a bigger issue if you're running selenium-grid-extras inside docker on different machines communicating between them.
I propose to use the selenium node custom configuration map to insert the property
grid-extras-port
so that the hub knows on which port is the grid-extras from the node listening on.