Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug #25

Closed
wants to merge 1 commit into from
Closed

Debug #25

wants to merge 1 commit into from

Conversation

bapt
Copy link
Contributor

@bapt bapt commented Sep 13, 2019

many i_info should be i_debug to avoid doveadm to be too verbose in production

@@ -482,7 +482,7 @@ static int fts_backend_xapian_lookup(struct fts_backend *_backend, struct mailbo
/* Performance calc */
gettimeofday(&tp, NULL);
dt = tp.tv_sec * 1000 + tp.tv_usec / 1000 - dt;
i_info("FTS Xapian: %ld results in %ld ms",n,dt);
i_debug("FTS Xapian: %ld results in %ld ms",n,dt);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is adequate, becuase if one need to put dovecot in debug mode, then all the debug messages comes, and fts debug gets lost. ALso performance data is quite usefull not in debug mode.

@@ -452,7 +449,7 @@ static void fts_backend_xapian_oldbox(struct xapian_fts_backend *backend)
}
/* End Performance calculator*/

i_info("FTS Xapian: Done indexing '%s' (%ld msgs in %ld ms, rate: %.1f)",backend->oldbox,backend->perf_nb,dt,r);
i_debug("FTS Xapian: Done indexing '%s' (%ld msgs in %ld ms, rate: %.1f)",backend->oldbox,backend->perf_nb,dt,r);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is adequate, becuase if one need to put dovecot in debug mode, then all the debug messages comes, and fts debug gets lost. ALso performance data is quite usefull not in debug mode.

@cmouse cmouse mentioned this pull request Oct 9, 2019
@bapt
Copy link
Contributor Author

bapt commented Oct 9, 2019

I do understand that, on the other hand, it makes the run of doveadm very verbose, making crontab and other commands that uses doveadm more verbose than expected with no way to turn it off. If you have ideas, I can implement them.

@grosjo
Copy link
Owner

grosjo commented Oct 9, 2019

@bapt to resolve teh matter, I would rather add a parameter in the config file (say "verbose true/false") which enables the debug info or not, so the administrator may decide if log info is neded or not for its own case

@bapt
Copy link
Contributor Author

bapt commented Oct 9, 2019

ok I will try to work on something like that when I do find the time.

@grosjo
Copy link
Owner

grosjo commented Oct 12, 2019

@bapt see recent changes (parameter "verbose")

@grosjo
Copy link
Owner

grosjo commented Oct 20, 2019

@bapt Let's continue on PR #27

@grosjo grosjo closed this Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants