Anonymous inner class: wrong "override method" result when a space is present

[mauromol]

Followup to #395 (where the mentioned I interface is defined).

Consider the following (watch carefully the whitespace characters!):

When you hit Ctrl+Space to add the unimplemented method mymethod you get:

When you have this, instead (please note the missing space after the last-but-one closed bracket):

Then you get the correct result:

Please note, however, that, even in the correct result, I would expect the cursor to be placed inside the implemented method body, not after its closing bracket.

[eric-milles]

The transfer of Groovy class members to the JDT model, especially method statements is very sensitive to the source position information. I needed to subtract 1 from the bodyEnd property of a MethodDeclaration for the body parsing to start succeeding. JDT is expecting that the body ends at the offset of the closing brace. Groovy has an end position for the closing brace or probably more correctly the next newline minus 1.

Your example with an extra space after the closing brace of a method body will need to be corrected for. The Antlr2 grammar has a bad tendency of sucking in those whitespaces as part of the token.

[eric-milles]

Ready to test

[mauromol]

This use case works well in 3.1.0.xx-201808311121-e47, thank you! 👍