Add support for Java 11 #686
Comments
|
|
|
@jonnermut It is possible to set up the IDE with Java 11 and Groovy, but the provisioning process is a bit involved. There was a misalignment between the new Java release schedule and the new Eclipse release schedule. Since Eclipse did not get Java 11 support into 4.9 and did not release a 4.9a, there is no easy way to apply the Groovy patch. Eclipse 4.10 (2018-12) will have Java 11 support baked in and so the Groovy patch will work normally. Until then, the code is available on the java11 branch in case you want to have a look at it our build it. |
|
Thanks @eric-milles , yeah I'm using the Java 11 support out of the Eclipse marketplace, (which is a one click install) as I'm migrating my project from 8->11, and at the moment there is no way to have that installed at the same time as Groovy-eclipse - installing one demands you to uninstall the other. |
|
To run the IDE from your workstation, you'd need to setup Eclipse PDE. In your PDE workspace you'd build Groovy-Eclipse and its target platform would be your current IDE. Then you'd run your current IDE from within your PDE workspace. This would allow you to overlay the Groovy-Eclipse plug-ins onto your Java 11 patched IDE. This can be time consuming to setup for the first time. I will be adding 4.10 to the java11 branch today or tomorrow. And as soon as 3.1.0 release is completed (should start building today), a build plan will be added for Eclipse 4.10 and the java11 branch will be merged to master. |
eric-milles
added a commit
that referenced
this issue
Oct 16, 2018
|
Eclipse 4.10 M1 has been patched on the java11 branch. At the moment, the update site Otherwise, you can export the feature |
|
Great, thanks a lot, I will give it a try. |
|
Those sites are already provided. They supply the newly updated plug-ins. However any stuff that is unchanged from the 2018-09 release is not yet available. <profile>
<id>e4.10</id>
<repositories>
<repository>
<id>2018-12</id>
<layout>p2</layout>
<url>http://download.eclipse.org/releases/2018-12</url>
</repository>
<repository>
<id>eclipse</id>
<layout>p2</layout>
<url>http://download.eclipse.org/eclipse/updates/4.10milestones</url>
</repository>
</repositories>
<modules>
<module>jdt-patch/e410/org.eclipse.jdt.core</module>
<module>jdt-patch/e410/org.eclipse.jdt.core.tests.builder</module>
<module>jdt-patch/e410/org.eclipse.jdt.core.tests.compiler</module>
<module>jdt-patch/e410/Feature-org.codehaus.groovy.jdt.patch</module>
</modules>
<properties>
<dist.target>e4.10</dist.target>
<greclipse.build.qualifier>'xx-'yyyyMMddHHmm'-e2018-12${dist.qualifier}'</greclipse.build.qualifier>
</properties>
</profile> |
|
I can't make head nor tail of how to build (or even import the project) in the PDE. I tried to put the repository back to 2018-09 for the maven pom, but that failed with a compile problem. I guess I will have to wait for that repo to be filled. But if anyone is able to build the groovy update site for 2018-12 M1 and dump it somewhere I would be very grateful - I have a huge java 11 upgrade branch ready to merge for my project that is waiting for proper IDE support - which in our case depends on having both the Eclipse Java 11 support and the groovy plugin cohabiting. |
|
I was able to figure out why the Maven build was failing. Intel x86 32-bit architecture support has been dropped. I updated the POM to follow suit. Build plan was created: https://build.spring.io/browse/GRECLIPSE-E410 |
|
Thanks Eric. I came back to this and was able to install from that update site on an updated eclipse.
The full exception is And there is a groovy compile error in the error log: I tried changing the groovy compiler from 2.4,2.5 & 2.6 but no difference. I also note that some of the files show the editor, but have spurious classpath errors (these imports are in the classpath, and work fine under 4.9 & Java 8):
Unfortunately the project is way too complex and proprietary to share. |
|
This was another stack with a slightly different bottom bit: |
|
For best results, you will need to run Eclipse with Java 11 as well. Until the modulepath is supported, there is a workaround to use the classloader of your running VM and this may result in conflicts if there are large differences between JRE types. |
|
Could you attach a small sample project so I can see what is going on under the covers? |
|
Running eclipse with Java 11 was identical except I got some extra glitchiness in eclipse... |
|
Is your project publicly available? |
|
Is geb.Page a type in your project or that you reference? When trying to resolve the method "$", it is getting tripped up on a parameter type that is an array. I am adding a check for ProblemReferenceBinding so we might get a bit more information from JDTClassNodeBuilder. What version of Groovy are you using? And are you using Java 9+ versions of any libraries? |
eric-milles
added a commit
that referenced
this issue
Nov 13, 2018
- also check for ProblemReferenceBinding #686
|
@jonnermut Just checking to see if you had a chance to try again with the last commit. Also, I wanted to mention that there have been several fixes to JDT Core since milestone 1. I have been waiting for milestone 2 to be released, but it is now 2 weeks overdue. Milestone 3 appears to be scheduled for next friday. Once it is available, I will update Groovy-Eclipse to match. |
eric-milles
added a commit
that referenced
this issue
Nov 23, 2018
eric-milles
added a commit
that referenced
this issue
Nov 30, 2018
eric-milles
added a commit
that referenced
this issue
Dec 7, 2018
eric-milles
added a commit
that referenced
this issue
Dec 19, 2018
eric-milles
added a commit
that referenced
this issue
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: