Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor and method context display not working #456

Closed
eric-milles opened this issue Feb 5, 2018 · 0 comments
Closed

Constructor and method context display not working #456

eric-milles opened this issue Feb 5, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@eric-milles
Copy link
Member

eric-milles commented Feb 5, 2018

After selecting a constructor or method completion and editing the resulting document, it should be possible to re-display the parameter information by initiating the same completion proposal just after the opening parenthesis or comma in the argument list.

The Java editor displays this as such:
javacontextdisplay

NOTE: CompletionNodeFinder.createContextForCallContext is the start of this process. It is working fine for constructors but not methods (at least ones without an object expression). Then GroovyJavaMethodCompletionProposal is not setting context information position for this case (first return statement in computeReplacementString(). Lastly, org.eclipse.jface.text.contentassist.CompletionProposalPopup.insertProposal circa line 1000 is not causing the context information to be displayed for some reason.

@eric-milles eric-milles added the bug label Feb 5, 2018
@eric-milles eric-milles added this to the v3.0.0 milestone Feb 5, 2018
@eric-milles eric-milles self-assigned this Feb 5, 2018
eric-milles added a commit that referenced this issue Feb 6, 2018
selection range should not be changed (or else cursor will move)
completion offset (in nested proposal) should be name end
context information position should be name end + 1
replacement offset should be cursor position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant