When code completion includes an import, conflicting names are not considered

[eric-milles]

Related to #367, #435 and #438 -- when code completion includes an import, conflicting names are not considered. This results in an import that shadows or is shadowed by another name in the scope.

//import static x.y.z.VALUE as NAME
//import static x.y.z.NAME
class C {
  //static Object NAME
  //Object NAME
  //static def NAME() {}
  // def NAME() {}
  void meth(/*def NAME*/) {
    //def NAME
   util(NA|) // completion on "NAME : E" proposal introduces static import that conflicts with any of the NAME declarations above
  }
  void util(E e) {}
}

package p;
enum E {
  NAME
}

A similar situation may exist if completion inserts "E.NAME" and "import p.E" and there is a name "E" in scope.

Partially- or fully-qualified names should be inserted in cases of conflict.

[eric-milles]

If org.eclipse.jdt.internal.corext.codemanipulation.ContextSensitiveImportRewriteContext.findInContext(String, String, int) can return a conflicting binding, then a qualifier will be used instead. This already occurs for types, fields, methods, properties.

[eric-milles]

TODO

1. static imports
2. for, catch, closure, try-with-resources parameters

[eric-milles]

Import conflicts are not handled by Java editor either. Bug filed with eclipse.org: https://bugs.eclipse.org/bugs/show_bug.cgi?id=542815