gmavenplus-plus plugin execution not covered since 1.6

[papegaaij]

In groovy/GMavenPlus#31 several goals were renamed. For example, testCompile is now compileTests. This causes errors like Plugin execution not covered by lifecycle configuration: org.codehaus.gmavenplus:gmavenplus-plugin:1.6:compileTests (execution: default, phase: test-compile).

[eric-milles]

Not sure if I follow. Is this a request to change something in groovy-eclipse-batch or groovy-eclipse-compiler artifacts?

[missedone]

if I read correct, @papegaaij means there need a fix in the default m2e lifecycle-mapping xml:
https://github.com/groovy/groovy-eclipse/blob/master/extras/org.codehaus.groovy.m2eclipse/lifecycle-mapping-metadata.xml#L67

looks like you need to define two portions, one is for <versionRange>[1.0,1.6)</versionRange>, and the other is for <versionRange>[1.6,)</versionRange>

[papegaaij]

What @missedone says. The lifecycle-mapping needs to be realligned with the new names of the goals. I'm not sure if this only applies to the lifecycle-mapping-metadata.xml. Maybe those names also show up in other parts of the code. For example, https://github.com/groovy/groovy-eclipse/blob/master/extras/org.codehaus.groovy.m2eclipse/src/org/codehaus/groovy/m2eclipse/ProjectSourceType.java#L95 also seems to refer to this goal name.

[eric-milles]

Sorry, I looked at the actual commits attached to the linked issue instead of the comments and have this instead:

    <pluginExecution>
      <pluginExecutionFilter>
        <groupId>org.codehaus.gmavenplus</groupId>
        <artifactId>gmavenplus-plugin</artifactId>
        <versionRange>[1.0,1.6)</versionRange>
        <goals>
          <goal>addSources</goal>
          <goal>addTestSources</goal>
          <goal>generateStubs</goal>
          <goal>compile</goal>
          <goal>removeStubs</goal>
          <goal>testGenerateStubs</goal>
          <goal>testCompile</goal>
          <goal>removeTestStubs</goal>
        </goals>
        </pluginExecutionFilter>
        <action>
          <configurator>
            <id>org.codehaus.groovy.m2eclipse.configurator</id>
          </configurator>
        </action>
    </pluginExecution>
    <pluginExecution>
      <pluginExecutionFilter>
        <groupId>org.codehaus.gmavenplus</groupId>
        <artifactId>gmavenplus-plugin</artifactId>
        <versionRange>[1.6,)</versionRange>
        <goals>
          <goal>addSources</goal>
          <goal>addTestSources</goal>
          <goal>generateStubs</goal>
          <goal>compile</goal>
          <goal>removeStubs</goal>
          <goal>generateTestStubs</goal>
          <goal>compileTests</goal>
          <goal>removeTestStubs</goal>
        </goals>
        </pluginExecutionFilter>
        <action>
          <configurator>
            <id>org.codehaus.groovy.m2eclipse.configurator</id>
          </configurator>
        </action>
    </pluginExecution>
  </pluginExecutions>

[papegaaij]

This change looks ok to me. In just over a week I'll have a chance to try updating again. If something else needs to be done, I'll report back. Thanks for the quick response.